Conversation
Sihun23
requested review from
joowojr and
starboxxxx
and removed request for
joowojr and
starboxxxx
hyoseong-Choi
approved these changes
Jan 30, 2025
parkjaehak
requested changes
Jan 31, 2025
src/main/java/clap/server/application/service/admin/SendInvitationService.java
Outdated
Show resolved
Hide resolved
joowojr
previously approved these changes
Jan 31, 2025
src/main/java/clap/server/application/service/admin/SendInvitationService.java
Outdated
Show resolved
Hide resolved
src/main/java/clap/server/application/service/admin/SendInvitationService.java
Outdated
Show resolved
Hide resolved
joowojr
requested changes
Jan 31, 2025
| NotificationType.INVITATION, // 알림 유형 | ||
| "회원가입 초대", // 작업 이름 | ||
| member.getMemberInfo().getName(), // 회원 이름 | ||
| member.getPassword(), // 초기 비밀번호 |
Contributor
There was a problem hiding this comment.
혹시 초기 비밀번호 생성하는 로직은 어디있을까요?
joowojr
approved these changes
Feb 2, 2025
Contributor
joowojr
left a comment
joowojr
left a comment
There was a problem hiding this comment.
수고하셨습니다! 코멘트 드린 부분만 수정하고 머지부탁드립니다
Contributor
There was a problem hiding this comment.
일단은 따로 클래스 분리가 아닌 email client안에 메서드로 선언해주시는게 좋을것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
변경 사항:
SendInvitationService에서 초대 이메일 전송 로직 구현
EmailClient에서 이메일 템플릿을 사용해 초대 이메일 전송 구현
초대 이메일 템플릿 파일 추가 (invitation.html)
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #79